Nrthugu

I am working with pulling data from a DB in WPF and doing it with multiple different tables, which I have modeled as POCO's in C#. I want to be able to create a method that is flexible enough to handle any of these POCO's being passed in, and then return an observable collection of the same class to the caller.

I have something set up that I haven't tested yet, but I know this probably isn't the best way to implement this so I wanted to get some advice on how to best do this before I even bothered troubleshooting or attempting to get this to work:

 public static ObservableCollection<object> SQLAuthentication(ObservableCollection<object> myCollection, object myClass, String sql)

        {

            var conn = new SqlConnection();



            var paramList = GenerateSQLParameters(myClass, null);

            var tempModel = Global.GenerateNewInstance(myClass);



            //get the type

            Type model = tempModel.GetType();

            var prop = model.GetProperties();

            PropertyInfo pi;



            using (getConnection(conn))

            {

                conn.Open();

                SqlCommand cmd;

                SqlDataReader reader;



                cmd = new SqlCommand(sql, conn);

                reader = cmd.ExecuteReader();



                while (reader.Read())

                {



                    //set the values for each property in the model

                    foreach (var p in prop)

                    {

                        pi = tempModel.GetType().GetProperty(p.Name);

                        pi.SetValue(tempModel, reader[p.Name]);

                    }

                   myCollection.Add(tempModel);

                }

                reader.Close();

                cmd.Dispose();

            }



            return myCollection;

        }

You can use generic types in the method signature its self, you dont need to use object collection... and as im writing this John B hit the nail on its head

public static ObservableCollection<T> SQLAuthentication(ObservableCollection<T> myCollection, T myClass, String sql) where T: class

@John, if you post it as an answer ill remove this since you did technically shout it out first, just leave a comment if you do so i get the notification