Upgrading from AngularJS 1.5 to 1.7 throws “Can't copy! Making copies of Window or Scope instances is not...












2














I would like to copy my controller.
I had the following code (invalid in angular 1.7):



link: function(scope, elm, attrs, ctrl) {
if (!ctrl) {
return;
}

// Do a copy of the controller
scope.ctrlCopy = {};
angular.copy(ctrl, scope.ctrlCopy); // <- fail here


This fails with:




Can't copy! Making copies of Window or Scope instances is not supported




I tried Object.copy but I need a prototype function of the controller ($setValidity)










share|improve this question





























    2














    I would like to copy my controller.
    I had the following code (invalid in angular 1.7):



    link: function(scope, elm, attrs, ctrl) {
    if (!ctrl) {
    return;
    }

    // Do a copy of the controller
    scope.ctrlCopy = {};
    angular.copy(ctrl, scope.ctrlCopy); // <- fail here


    This fails with:




    Can't copy! Making copies of Window or Scope instances is not supported




    I tried Object.copy but I need a prototype function of the controller ($setValidity)










    share|improve this question



























      2












      2








      2







      I would like to copy my controller.
      I had the following code (invalid in angular 1.7):



      link: function(scope, elm, attrs, ctrl) {
      if (!ctrl) {
      return;
      }

      // Do a copy of the controller
      scope.ctrlCopy = {};
      angular.copy(ctrl, scope.ctrlCopy); // <- fail here


      This fails with:




      Can't copy! Making copies of Window or Scope instances is not supported




      I tried Object.copy but I need a prototype function of the controller ($setValidity)










      share|improve this question















      I would like to copy my controller.
      I had the following code (invalid in angular 1.7):



      link: function(scope, elm, attrs, ctrl) {
      if (!ctrl) {
      return;
      }

      // Do a copy of the controller
      scope.ctrlCopy = {};
      angular.copy(ctrl, scope.ctrlCopy); // <- fail here


      This fails with:




      Can't copy! Making copies of Window or Scope instances is not supported




      I tried Object.copy but I need a prototype function of the controller ($setValidity)







      javascript angularjs deep-copy






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 12 '18 at 9:21









      Rob

      37k1899128




      37k1899128










      asked Nov 12 '18 at 7:32









      IsraGab

      1,83911432




      1,83911432
























          1 Answer
          1






          active

          oldest

          votes


















          1














          I do it like this:



          scope.ctrlCopy = Object.assign(Object.create(ctrl.__proto__), ctrl);


          Where Object.create(ctrl.__proto__) is used to create prototype functions
          And assign to create the deep copy.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53257604%2fupgrading-from-angularjs-1-5-to-1-7-throws-cant-copy-making-copies-of-window%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            1














            I do it like this:



            scope.ctrlCopy = Object.assign(Object.create(ctrl.__proto__), ctrl);


            Where Object.create(ctrl.__proto__) is used to create prototype functions
            And assign to create the deep copy.






            share|improve this answer


























              1














              I do it like this:



              scope.ctrlCopy = Object.assign(Object.create(ctrl.__proto__), ctrl);


              Where Object.create(ctrl.__proto__) is used to create prototype functions
              And assign to create the deep copy.






              share|improve this answer
























                1












                1








                1






                I do it like this:



                scope.ctrlCopy = Object.assign(Object.create(ctrl.__proto__), ctrl);


                Where Object.create(ctrl.__proto__) is used to create prototype functions
                And assign to create the deep copy.






                share|improve this answer












                I do it like this:



                scope.ctrlCopy = Object.assign(Object.create(ctrl.__proto__), ctrl);


                Where Object.create(ctrl.__proto__) is used to create prototype functions
                And assign to create the deep copy.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 12 '18 at 8:55









                IsraGab

                1,83911432




                1,83911432






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53257604%2fupgrading-from-angularjs-1-5-to-1-7-throws-cant-copy-making-copies-of-window%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Full-time equivalent

                    さくらももこ

                    13 indicted, 8 arrested in Calif. drug cartel investigation