Tidying up a powershell script
So I need help tidying up a script that I have. The purpose of this script is to make 18 different sql files based on the data below 18 different column headers. What my script does now is make 1 sql file based on which column I choose to input via "Read-Host". This is my current script
function get-header
{Read-Host "Type the Column header betwen B-Z for which sql files needs to be created"
}
function get-column
{
Read-Host "Type the Column number"
}
do
{
$val = get-header
}
while(!($val))
do
{$col = get-column
}
while(!($col))
switch ($val)
{
"B"{$column = "1"}
"C"{$column = "2"}
"D"{$column = "3"}
"E"{$column = "4"}
"F"{$column = "5"}
"G"{$column = "6"}
"H"{$column = "7"}
"I"{$column = "8"}
"J"{$column = "9"}
"K"{$column = "10"}
"L"{$column = "11"}
"M"{$column = "12"}
"N"{$column = "13"}
"O"{$column = "14"}
"P"{$column = "15"}
"Q"{$column = "16"}
"R"{$column = "17"}
"S"{$column = "18"}
"T"{$column = "19"}
"U"{$column = "20"}
"V"{$column = "21"}
"W"{$column = "22"}
"X"{$column = "23"}
"Y"{$column = "24"}
"Z"{$column = "25"}
default { $column = 'Unknown' }
}
if ($column -eq 'Unknown')
{
Write-Warning "Not a valid input"
return
}
$csv = Import-Csv "Indices Updates - September 2018.csv" -Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26
$date = (Get-Date -Format "MM/dd/yyyy").Replace("-","/")
$sql = @("INSERT INTO benchmark_values(created_at,benchmark_id,date,amount,created_by_username)
foreach($data in $csv)
{
$secondcolumn = [int]$column + 1
$sql += "('$date',$col,'$($data.1)',$($data.$secondcolumn),'BPylla'),"
}
$sql | Out-File "sqldata.sql"
Now I want to get rid of read-host entirely because I dont want to input any values. I also will give an example of what the csv file looks like and what the sql file should look like.
So the goal is to produce different sql files from each column of information using the the sql format posted. I already have the template for that in my script now, I just need the script to create all the sql files based on headers and still input the data below the headers in the new sql files. Any help would be greatly appreciated! Thanks!
powershell
edited Nov 12 '18 at 22:30
mklement0
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
|
show 2 more comments
So I need help tidying up a script that I have. The purpose of this script is to make 18 different sql files based on the data below 18 different column headers. What my script does now is make 1 sql file based on which column I choose to input via "Read-Host". This is my current script
function get-header
{Read-Host "Type the Column header betwen B-Z for which sql files needs to be created"
}
function get-column
{
Read-Host "Type the Column number"
}
do
{
$val = get-header
}
while(!($val))
do
{$col = get-column
}
while(!($col))
switch ($val)
{
"B"{$column = "1"}
"C"{$column = "2"}
"D"{$column = "3"}
"E"{$column = "4"}
"F"{$column = "5"}
"G"{$column = "6"}
"H"{$column = "7"}
"I"{$column = "8"}
"J"{$column = "9"}
"K"{$column = "10"}
"L"{$column = "11"}
"M"{$column = "12"}
"N"{$column = "13"}
"O"{$column = "14"}
"P"{$column = "15"}
"Q"{$column = "16"}
"R"{$column = "17"}
"S"{$column = "18"}
"T"{$column = "19"}
"U"{$column = "20"}
"V"{$column = "21"}
"W"{$column = "22"}
"X"{$column = "23"}
"Y"{$column = "24"}
"Z"{$column = "25"}
default { $column = 'Unknown' }
}
if ($column -eq 'Unknown')
{
Write-Warning "Not a valid input"
return
}
$csv = Import-Csv "Indices Updates - September 2018.csv" -Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26
$date = (Get-Date -Format "MM/dd/yyyy").Replace("-","/")
$sql = @("INSERT INTO benchmark_values(created_at,benchmark_id,date,amount,created_by_username)
foreach($data in $csv)
{
$secondcolumn = [int]$column + 1
$sql += "('$date',$col,'$($data.1)',$($data.$secondcolumn),'BPylla'),"
}
$sql | Out-File "sqldata.sql"
Now I want to get rid of read-host entirely because I dont want to input any values. I also will give an example of what the csv file looks like and what the sql file should look like.
So the goal is to produce different sql files from each column of information using the the sql format posted. I already have the template for that in my script now, I just need the script to create all the sql files based on headers and still input the data below the headers in the new sql files. Any help would be greatly appreciated! Thanks!
powershell
edited Nov 12 '18 at 22:30
mklement0
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
It's not clear to me what you are after. Just a hint instead of-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26simply use-Header @(1..26)
– LotPings
Nov 12 '18 at 23:44
Also most of your switch could be replaced by calculating$Column=([int][char]$Val.ToUpper())-65
– LotPings
Nov 12 '18 at 23:50
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
1
@LotPings: Or, even simpler:-Header (1..26)-@(...)is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs[object], irrespective of the input array type - try@([int] (1..3)).GetType().Name).
– mklement0
Nov 13 '18 at 4:08
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06
|
show 2 more comments
So I need help tidying up a script that I have. The purpose of this script is to make 18 different sql files based on the data below 18 different column headers. What my script does now is make 1 sql file based on which column I choose to input via "Read-Host". This is my current script
function get-header
{Read-Host "Type the Column header betwen B-Z for which sql files needs to be created"
}
function get-column
{
Read-Host "Type the Column number"
}
do
{
$val = get-header
}
while(!($val))
do
{$col = get-column
}
while(!($col))
switch ($val)
{
"B"{$column = "1"}
"C"{$column = "2"}
"D"{$column = "3"}
"E"{$column = "4"}
"F"{$column = "5"}
"G"{$column = "6"}
"H"{$column = "7"}
"I"{$column = "8"}
"J"{$column = "9"}
"K"{$column = "10"}
"L"{$column = "11"}
"M"{$column = "12"}
"N"{$column = "13"}
"O"{$column = "14"}
"P"{$column = "15"}
"Q"{$column = "16"}
"R"{$column = "17"}
"S"{$column = "18"}
"T"{$column = "19"}
"U"{$column = "20"}
"V"{$column = "21"}
"W"{$column = "22"}
"X"{$column = "23"}
"Y"{$column = "24"}
"Z"{$column = "25"}
default { $column = 'Unknown' }
}
if ($column -eq 'Unknown')
{
Write-Warning "Not a valid input"
return
}
$csv = Import-Csv "Indices Updates - September 2018.csv" -Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26
$date = (Get-Date -Format "MM/dd/yyyy").Replace("-","/")
$sql = @("INSERT INTO benchmark_values(created_at,benchmark_id,date,amount,created_by_username)
foreach($data in $csv)
{
$secondcolumn = [int]$column + 1
$sql += "('$date',$col,'$($data.1)',$($data.$secondcolumn),'BPylla'),"
}
$sql | Out-File "sqldata.sql"
Now I want to get rid of read-host entirely because I dont want to input any values. I also will give an example of what the csv file looks like and what the sql file should look like.
So the goal is to produce different sql files from each column of information using the the sql format posted. I already have the template for that in my script now, I just need the script to create all the sql files based on headers and still input the data below the headers in the new sql files. Any help would be greatly appreciated! Thanks!
powershell
edited Nov 12 '18 at 22:30
mklement0
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
So I need help tidying up a script that I have. The purpose of this script is to make 18 different sql files based on the data below 18 different column headers. What my script does now is make 1 sql file based on which column I choose to input via "Read-Host". This is my current script
function get-header
{Read-Host "Type the Column header betwen B-Z for which sql files needs to be created"
}
function get-column
{
Read-Host "Type the Column number"
}
do
{
$val = get-header
}
while(!($val))
do
{$col = get-column
}
while(!($col))
switch ($val)
{
"B"{$column = "1"}
"C"{$column = "2"}
"D"{$column = "3"}
"E"{$column = "4"}
"F"{$column = "5"}
"G"{$column = "6"}
"H"{$column = "7"}
"I"{$column = "8"}
"J"{$column = "9"}
"K"{$column = "10"}
"L"{$column = "11"}
"M"{$column = "12"}
"N"{$column = "13"}
"O"{$column = "14"}
"P"{$column = "15"}
"Q"{$column = "16"}
"R"{$column = "17"}
"S"{$column = "18"}
"T"{$column = "19"}
"U"{$column = "20"}
"V"{$column = "21"}
"W"{$column = "22"}
"X"{$column = "23"}
"Y"{$column = "24"}
"Z"{$column = "25"}
default { $column = 'Unknown' }
}
if ($column -eq 'Unknown')
{
Write-Warning "Not a valid input"
return
}
$csv = Import-Csv "Indices Updates - September 2018.csv" -Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26
$date = (Get-Date -Format "MM/dd/yyyy").Replace("-","/")
$sql = @("INSERT INTO benchmark_values(created_at,benchmark_id,date,amount,created_by_username)
foreach($data in $csv)
{
$secondcolumn = [int]$column + 1
$sql += "('$date',$col,'$($data.1)',$($data.$secondcolumn),'BPylla'),"
}
$sql | Out-File "sqldata.sql"
Now I want to get rid of read-host entirely because I dont want to input any values. I also will give an example of what the csv file looks like and what the sql file should look like.
So the goal is to produce different sql files from each column of information using the the sql format posted. I already have the template for that in my script now, I just need the script to create all the sql files based on headers and still input the data below the headers in the new sql files. Any help would be greatly appreciated! Thanks!
powershell
powershell
edited Nov 12 '18 at 22:30
mklement0
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
edited Nov 12 '18 at 22:30
mklement0
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
edited Nov 12 '18 at 22:30
mklement0
128k20241270
edited Nov 12 '18 at 22:30
mklement0
128k20241270
edited Nov 12 '18 at 22:30
mklement0
128k20241270
128k20241270
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
asked Nov 12 '18 at 21:55
Andrew FortesAndrew Fortes
1
1
It's not clear to me what you are after. Just a hint instead of-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26simply use-Header @(1..26)
– LotPings
Nov 12 '18 at 23:44
Also most of your switch could be replaced by calculating$Column=([int][char]$Val.ToUpper())-65
– LotPings
Nov 12 '18 at 23:50
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
1
@LotPings: Or, even simpler:-Header (1..26)-@(...)is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs[object], irrespective of the input array type - try@([int] (1..3)).GetType().Name).
– mklement0
Nov 13 '18 at 4:08
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06
|
show 2 more comments
It's not clear to me what you are after. Just a hint instead of-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26simply use-Header @(1..26)
– LotPings
Nov 12 '18 at 23:44
Also most of your switch could be replaced by calculating$Column=([int][char]$Val.ToUpper())-65
– LotPings
Nov 12 '18 at 23:50
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
1
@LotPings: Or, even simpler:-Header (1..26)-@(...)is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs[object], irrespective of the input array type - try@([int] (1..3)).GetType().Name).
– mklement0
Nov 13 '18 at 4:08
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06
It's not clear to me what you are after. Just a hint instead of
-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26 simply use -Header @(1..26)– LotPings
Nov 12 '18 at 23:44
It's not clear to me what you are after. Just a hint instead of
-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26 simply use -Header @(1..26)– LotPings
Nov 12 '18 at 23:44
Also most of your switch could be replaced by calculating
$Column=([int][char]$Val.ToUpper())-65– LotPings
Nov 12 '18 at 23:50
Also most of your switch could be replaced by calculating
$Column=([int][char]$Val.ToUpper())-65– LotPings
Nov 12 '18 at 23:50
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
1
1
@LotPings: Or, even simpler:
-Header (1..26) - @(...) is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs [object], irrespective of the input array type - try @([int] (1..3)).GetType().Name).– mklement0
Nov 13 '18 at 4:08
@LotPings: Or, even simpler:
-Header (1..26) - @(...) is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs [object], irrespective of the input array type - try @([int] (1..3)).GetType().Name).– mklement0
Nov 13 '18 at 4:08
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06
|
show 2 more comments
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53270665%2ftidying-up-a-powershell-script%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53270665%2ftidying-up-a-powershell-script%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
It's not clear to me what you are after. Just a hint instead of
-Header 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26simply use-Header @(1..26)– LotPings
Nov 12 '18 at 23:44
Also most of your switch could be replaced by calculating
$Column=([int][char]$Val.ToUpper())-65– LotPings
Nov 12 '18 at 23:50
Does that $column variable give you the column data?
– Andrew Fortes
Nov 13 '18 at 3:09
1
@LotPings: Or, even simpler:
-Header (1..26)-@(...)is never needed for expressions you know to be arrays (and is not only inefficient, but always outputs[object], irrespective of the input array type - try@([int] (1..3)).GetType().Name).– mklement0
Nov 13 '18 at 4:08
@mklement0 so where and how would you apply that to the current script?
– Andrew Fortes
Nov 13 '18 at 16:06