Linux Bash Shell Script

up vote
-1
down vote

favorite

What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.

# Skript: M122_Scripts/addPerson.sh

echo "Write youre name (: end with quit"

read $Name 

while true; do

if [ "$Name" = "quit" ]; then

echo "exit add person"

break

else

echo $name >> Filelist

echo $name

read $name

fi

done

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

1

Add a shebang and then paste your script there: shellcheck.net
– Cyrus
yesterday

1

$Name != $name
– Cyrus
yesterday

Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
yesterday

read $Name should be read Name (no $)
– William Pursell
9 hours ago

add a comment |

up vote
-1
down vote

favorite

What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.

# Skript: M122_Scripts/addPerson.sh

echo "Write youre name (: end with quit"

read $Name 

while true; do

if [ "$Name" = "quit" ]; then

echo "exit add person"

break

else

echo $name >> Filelist

echo $name

read $name

fi

done

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

1

Add a shebang and then paste your script there: shellcheck.net
– Cyrus
yesterday

1

$Name != $name
– Cyrus
yesterday

Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
yesterday

read $Name should be read Name (no $)
– William Pursell
9 hours ago

add a comment |

up vote
-1
down vote

favorite

What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.

# Skript: M122_Scripts/addPerson.sh

echo "Write youre name (: end with quit"

read $Name 

while true; do

if [ "$Name" = "quit" ]; then

echo "exit add person"

break

else

echo $name >> Filelist

echo $name

read $name

fi

done

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.

# Skript: M122_Scripts/addPerson.sh

echo "Write youre name (: end with quit"

read $Name 

while true; do

if [ "$Name" = "quit" ]; then

echo "exit add person"

break

else

echo $name >> Filelist

echo $name

read $name

fi

done

linux bash shell scripting

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

edited yesterday

Cyrus

44.1k43375

edited yesterday

Cyrus

44.1k43375

edited yesterday

Cyrus

44.1k43375

asked yesterday

blend tahiri

asked yesterday

blend tahiri

asked yesterday

blend tahiri

1

Add a shebang and then paste your script there: shellcheck.net
– Cyrus
yesterday

1

$Name != $name
– Cyrus
yesterday

Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
yesterday

read $Name should be read Name (no $)
– William Pursell
9 hours ago

add a comment |

1

Add a shebang and then paste your script there: shellcheck.net
– Cyrus
yesterday

1

$Name != $name
– Cyrus
yesterday

Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
yesterday

read $Name should be read Name (no $)
– William Pursell
9 hours ago

Add a shebang and then paste your script there: shellcheck.net
– Cyrus
yesterday

$Name != $name
– Cyrus
yesterday

Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
yesterday

read $Name should be read Name (no $)
– William Pursell
9 hours ago

add a comment |

1 Answer
1

active

oldest

votes

up vote
2
down vote

There are some mistakes in your script, try this:

#!/bin/bash



echo "Write youre name (: end with quit"

# wrong: read $Name

read Name

while true; do

    if [ "$Name" = "quit" ]; then

        echo "exit add person"

        break

    else

        echo $Name >> Filelist

        echo $Name

        # wrong: read $name

        read Name

    fi

done

edited 9 hours ago

answered yesterday

ssemilla

1,696313

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

add a comment |

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53237865%2flinux-bash-shell-script%23new-answer', 'question_page');
}
);

Post as a guest

Name

1 Answer
1

active

oldest

votes

1 Answer
1

active

oldest

votes

up vote
2
down vote

There are some mistakes in your script, try this:

#!/bin/bash



echo "Write youre name (: end with quit"

# wrong: read $Name

read Name

while true; do

    if [ "$Name" = "quit" ]; then

        echo "exit add person"

        break

    else

        echo $Name >> Filelist

        echo $Name

        # wrong: read $name

        read Name

    fi

done

edited 9 hours ago

answered yesterday

ssemilla

1,696313

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

add a comment |

up vote
2
down vote

There are some mistakes in your script, try this:

#!/bin/bash



echo "Write youre name (: end with quit"

# wrong: read $Name

read Name

while true; do

    if [ "$Name" = "quit" ]; then

        echo "exit add person"

        break

    else

        echo $Name >> Filelist

        echo $Name

        # wrong: read $name

        read Name

    fi

done

edited 9 hours ago

answered yesterday

ssemilla

1,696313

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

add a comment |

up vote
2
down vote

There are some mistakes in your script, try this:

#!/bin/bash



echo "Write youre name (: end with quit"

# wrong: read $Name

read Name

while true; do

    if [ "$Name" = "quit" ]; then

        echo "exit add person"

        break

    else

        echo $Name >> Filelist

        echo $Name

        # wrong: read $name

        read Name

    fi

done

edited 9 hours ago

answered yesterday

ssemilla

1,696313

There are some mistakes in your script, try this:

#!/bin/bash



echo "Write youre name (: end with quit"

# wrong: read $Name

read Name

while true; do

    if [ "$Name" = "quit" ]; then

        echo "exit add person"

        break

    else

        echo $Name >> Filelist

        echo $Name

        # wrong: read $name

        read Name

    fi

done

edited 9 hours ago

answered yesterday

ssemilla

1,696313

edited 9 hours ago

answered yesterday

ssemilla

1,696313

answered yesterday

ssemilla

1,696313

answered yesterday

ssemilla

1,696313

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

add a comment |

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

I've added the # wrong: comments for visibility of the changes
– ssemilla
yesterday

Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
yesterday

[ "$Name" = "quit" ] is not wrong.
– oguzismail
yesterday

Okay, downvote removed
– oguzismail
9 hours ago

add a comment |

draft saved

draft discarded

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Name

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Nrthugu